Repository navigation
chore(lint): add eslint and prettier with ionic configs and CI workflow - #183
Open
brandyscarney wants to merge 10 commits into
Open
brandyscarney wants to merge 10 commits into
brandyscarney wants to merge 10 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
force-pushed
the
chore/add-lint-workflow
branch
from
November 9, 2026 21:30
2464fc0 to
80ddbf8
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Adds linting and formatting to the React conference app using Ionic's shared ESLint and Prettier configs, and adds a CI workflow on Node 26 that checks every pull request.
New Behavior
npm run lintchecks the code with ESLint, then Prettier.npm run lint:fixfixes what it can automatically..nvmrc.nvm use(or fnm) picks it up locally.Changes
@ionic/eslint-config(recommended) pluseslint-plugin-react-hooksandeslint-plugin-react-refresh. The repo had no ESLint installed, only a leftoverreact-appconfig inpackage.json, which is removed.@ionic/prettier-config, replacing.prettierrcand theformatscript. The source is reformatted, and the remaining lint errors are fixed.import-x/orderrule. Each page's stylesheet import comes last, andApp.tsximports its global CSS first, so page styles still load after Ionic's CSS.lint,lint:fix,eslint, andprettier.github/workflows/CI.yml, with aconcurrencygroup per pull request and the Test jobs named by OS only, so Node updates don't rename the required checks..nvmrcwith26. Everyactions/setup-nodestep reads it, inCI.ymlandcapacitor-sync.yml.renovate.json:@ionic/eslint-configand@ionic/prettier-configmove out of theionicgroup and into the dev-tools group, along with ESLint and its plugins.vscode/extensions.json.prettierignoreforandroid/andios/: Prettier only reads the root.gitignore, so it would otherwise check Capacitor's copied web build and Gradle's build outputCONTRIBUTING.mdNotes
@typescript-eslint/explicit-module-boundary-typesis set towarnhere (the level in Ionic's base config). The next PR fixes those warnings and makes the rule an error again.react-refresh/only-export-components(pages export aconnect()-wrapped default),no-empty-object-type, andno-unused-expressions.Menu.cssnow loads after Ionic's CSS like the other components, and a few page stylesheets swap places. None of the reordered rules set the same property on the same element, so nothing renders differently.react-refresh/only-export-componentsstays on, configured to recognize the customconnect()HOC that pages are wrapped in.AppContextis split intoAppContext.ts(the context) andAppContextProvider.tsx(the provider component), so every file exports only components or only non-components."type": "module"), like the React tutorial app, so the config iseslint.config.js, and Vite no longer warns about loadingvite.config.tsas CommonJS.