Repository navigation
Conversation
thetaPC
added this pull request to stack #31629
October 22, 2026 22:56
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 of 2 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
md buttons use values carried over from v9 instead of Material Design 2: 15.4px padding,
0.06emtracking, a 2px outline in the button's color, a 0.5 fade when disabled, and the same elevation on hover and focus as at rest.What is the new behavior?
md buttons follow Material Design 2, using the values from Material Components Web 14, Google's MD2 implementation:
0.0893emletter spacingTo support this, the recipe gains
hover.box.shadow,focus.box.shadowanddisabled.{color, border.color, box.shadow}. A theme that doesn't set the disabled colors keeps its default colors, so ios and ionic don't change.Toolbar and datetime buttons keep their current look: no elevation on hover or focus, and disabled toolbar buttons still fade their own colors.
Snapshots are in #.
Does this introduce a breaking change?
The
mdbutton follows Material Design 2 for its spacing, outline, elevation and disabled state. To keep a previous value, set the token for global styles, or the matching--ion-button-*CSS variable for component-specific styles. Replace<fill>withsolid,outlineorclear, and<size>withsmall,mediumorlarge.1.1em16pxIonButton.size.medium.padding.startand.end64pxIonButton.size.medium.min.width0.06em0.0893emIonButton.letter.spacing1.35em1.2857em(18pxat the default size)IonButton.size.<size>.icon.font.size0.3em0.5714em(8pxat the default size)IonButton.size.<size>.icon.leading.margin.endand.trailing.margin.start2px, the button's color1px, the text color at12%IonButton.hue.bold.outline.default.border.widthand.color(.semantic.default.border.colorwith acolor)IonButton.hue.bold.solid.hover.box.shadowand.focus.box.shadow0.5opacity38%text color, a12%container and no elevationIonButton.hue.bold.<fill>.disabled.opacity,.color,.backgroundand.box.shadow16%24%on solid,12%on outline and clearIonButton.hue.bold.<fill>.rippleEffect.opacityButtons in toolbars keep their previous colors when disabled and have no elevation on hover or focus.
Other information
Not matched to MD2 on purpose
rounddefault from feat(button): set default shape to soft for ios and round for md and ionic themes #29404 staysKnown gaps
TODO(FW-6838)). The lighter ripple raises its contrast from 4.09 to 4.37:1, under WCAG's 4.5:1. The fix belongs to the dark paletteHow to test