Repository navigation
fix(config): apply app config over theme config - #31635
Open
brandyscarney wants to merge 1 commit into
Open
brandyscarney wants to merge 1 commit into
brandyscarney wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
force-pushed
the
FW-7803
branch
from
October 22, 2026 20:10
479022f to
a36544b
Compare
brandyscarney
marked this pull request as ready for review
October 22, 2026 20:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Config can be set by the app (
window.Ionic.config/setupConfig) and by a theme'sconfigblock.initialize()applies the app config first and the theme's config on top, so the theme wins:rippleEffect: true, an app that setsrippleEffect: falsestill gets ripples.screenBreakpoints: { md: 500 }is overridden by a theme'smd: 700.Only the custom theme's
configblock is read. The base theme'sconfigis never applied, whether or not a custom theme is supplied.What is the new behavior?
screenBreakpoints, the theme fills in only the keys the app did not set.configis now applied, merged with the custom theme when one is supplied.rippleEffect: false. See below.Why the base theme no longer sets
rippleEffectApplying the base config makes its values real, and for most apps base is the only theme config that applies. A theme's token file is only loaded when the app passes it as
customTheme. An app that uses md, either by default off iOS or by settingtheme: 'md', gets the base tokens only. md'srippleEffect: truenever loads.Tap-click drives every ripple and reads
config.getBoolean('rippleEffect', true). TodayrippleEffectis unset for these apps, so it falls back totrueand ripples work, matchingmain. If base keptrippleEffect: false, that value would now be applied and tap-click would stop showing ripples for every md app that doesn't supply a custom theme:customThemerippleEffectmaintruefalsefalsetrueRemoving it from base leaves ripple behavior unchanged everywhere. md's token file still sets
true. The remaining base value,formHighlight: false, has no runtime reader yet, so applying it changes nothing.Once choosing a theme loads that theme's tokens, md's
truewill always layer over base. Base can then setrippleEffect: false, and the tap-click and chip fallbacks can be removed. That work is tracked in FW-7893, along with renamingcustomThemetotheme.Does this introduce a breaking change?