Repository navigation
Conversation
|
@Marve10s is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30374
What is the current behavior?
Ionic page lifecycle hooks bypass Vue's error handling. Rejected promises do not reach
onErrorCapturedorapp.config.errorHandler, and synchronous throws can interrupt the page transition and leave the page invisible.What is the new behavior?
Composition API hooks, component options, and instance methods invoke callbacks through Vue's
callWithAsyncErrorHandling, using the owning component instance. Errors follow Vue's normal capture and propagation rules. A handled failure allows navigation to complete, while callback receivers, arguments, and return values are preserved.The existing Vue test app includes a reproduction at
/lifecycle-errors?api=composition&async=false. It also acceptsapi=optionsandasync=trueto exercise all four combinations.Does this introduce a breaking change?
Other information
All 52 new regression cases fail against the original bundle and pass with this change. The full Vue unit suite passes all 125 tests. Package lint, typecheck, build, and the reproduction app build pass. The tests use real Vue components, Ionic router, and outlet in jsdom; browser e2e tests were not run locally.
The error diagnostic uses Vue's existing
transition hookcategory. Unhandled errors continue to follow Vue's normal policy.