fix(android): update reply proxy before plugin call - #8617
Open
MateStrysewske wants to merge 1 commit into
Open
MateStrysewske wants to merge 1 commit into
MateStrysewske wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the reply proxy before dispatching a page's first call to avoid quick replies going through the old proxy.
Change Type
Rationale / Problems Fixed
Fixes #8616
Tests or Reproductions
In an app whose module graph starts with a top-level
await Preferences.get(...), running the instrumentation suite on an Android 16 emulator, where the tests reload the WebView between steps:Preferences.getleaving the page and nothing following it whileevaluateJavascriptprobes keep answering.yarn patchon 8.4.0), the blank pages disappear and the same first call is followed by the rest of the startup.Platforms Affected