Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem like CI ran with updated Xcode version because there are no plugin changes, just checking if we've done that or not, otherwise can we be sure that the CI is working?

I suppose we can find that out whenever we make plugin changes in the future, but doesn't hurt to check now?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check how? make some change in all plugins and then revert it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done that in the past myself yeah. Since we're squashing commits it doesn't really reflect in the end result.

But if you think it's not necessary then it can be merged as-is. I'll approve the PR.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run verify:ios locally with Xcode 27.0 and it built correcly, so I think we are fine.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough!

Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macos-15]
os: [ubuntu-latest, xcode-27]
timeout-minutes: 30
outputs:
plugins: ${{ steps.packages.outputs.paths }}
Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:
files: ${{ steps.catjson.outputs.FILES_JSON }}

lint-scripts:
runs-on: macos-15
runs-on: xcode-27
timeout-minutes: 30
needs:
- setup
Expand All @@ -70,7 +70,7 @@ jobs:
- run: npm run lint

lint:
runs-on: macos-15
runs-on: xcode-27
timeout-minutes: 30
needs:
- setup
Expand All @@ -97,7 +97,7 @@ jobs:
working-directory: ${{ matrix.plugin }}

verify-ios:
runs-on: macos-15
runs-on: xcode-27
if: needs.setup.outputs.plugins != '[]'
timeout-minutes: 30
needs:
Expand All @@ -107,7 +107,7 @@ jobs:
strategy:
matrix:
xcode:
- /Applications/Xcode_26.0.app
- /Applications/Xcode_27.0.app
plugin: ${{ fromJson(needs.setup.outputs.plugins) }}
steps:
- run: sudo xcode-select --switch ${{ matrix.xcode }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ on:
required: true
jobs:
publish-ios:
runs-on: macos-15
runs-on: xcode-27
if: github.event.inputs.plugins != '[]'
timeout-minutes: 30
strategy:
matrix:
plugin: ${{ fromJson(github.event.inputs.plugins) }}
steps:
- run: sudo xcode-select --switch /Applications/Xcode_26.0.app
- run: sudo xcode-select --switch /Applications/Xcode_27.0.app
- run: xcrun simctl list > /dev/null
- run: xcodebuild -downloadPlatform iOS
- uses: actions/setup-node@v7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-npm-alpha.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ permissions:

jobs:
deploy-npm-alpha:
runs-on: macos-15
runs-on: xcode-27
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-npm-beta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ permissions:

jobs:
deploy-npm-beta:
runs-on: macos-15
runs-on: xcode-27
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-npm-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ permissions:

jobs:
deploy-npm-dev:
runs-on: macos-15
runs-on: xcode-27
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-npm-latest-from-pre.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:
jobs:
deploy-npm-latest-from-pre:
if: github.ref == 'refs/heads/main'
runs-on: macos-15
runs-on: xcode-27
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-npm-latest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ permissions:
jobs:
deploy-npm-latest:
if: github.ref == 'refs/heads/main'
runs-on: macos-15
runs-on: xcode-27
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-npm-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions:
jobs:
deploy-npm-nightly:
if: github.ref == 'refs/heads/main'
runs-on: macos-15
runs-on: xcode-27
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-npm-rc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ permissions:

jobs:
deploy-npm-rc:
runs-on: macos-15
runs-on: xcode-27
timeout-minutes: 30
steps:
- uses: actions/checkout@v7
Expand Down
Loading