Skip to content

fix(ios): resolve requestPermissions for geolocation once the user answers #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andredestro wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −4
Open

fix(ios): resolve requestPermissions for geolocation once the user answers #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions ...ges/capacitor-plugin/ios/Sources/CapacitorBackgroundRunner/CapacitorAPI/Geolocation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class CapacitorGeolocation: NSObject, CapacitorGeolocationExports, CLLocationMan
private let locationManager: CLLocationManager

private var permissionContinuation: CheckedContinuation<Void, Error>?
private var permissionLocationManager: CLLocationManager?

var isWatchingPosition: Bool {
return isWatchingLocation
Expand Down Expand Up @@ -85,7 +86,12 @@ class CapacitorGeolocation: NSObject, CapacitorGeolocationExports, CLLocationMan
permissionContinuation = continuation

DispatchQueue.main.async {
self.locationManager.requestAlwaysAuthorization()
// Core Location delivers delegate callbacks on the run loop of the thread that created
// the manager, and this may run off the main thread, so ask through a main-thread manager.
let manager = CLLocationManager()
manager.delegate = self
self.permissionLocationManager = manager
manager.requestAlwaysAuthorization()
}
})
}
Expand Down Expand Up @@ -166,6 +172,7 @@ class CapacitorGeolocation: NSObject, CapacitorGeolocationExports, CLLocationMan
if let continuation = permissionContinuation {
continuation.resume(throwing: error)
permissionContinuation = nil
permissionLocationManager = nil
}

if let context = context, self.isWatchingLocation {
Expand All @@ -183,10 +190,13 @@ class CapacitorGeolocation: NSObject, CapacitorGeolocationExports, CLLocationMan
}

func locationManagerDidChangeAuthorization(_ manager: CLLocationManager) {
if let continuation = permissionContinuation {
continuation.resume()
permissionContinuation = nil
// Also called as soon as the delegate is set, while still undetermined: wait for the user's answer.
guard manager.authorizationStatus != .notDetermined, let continuation = permissionContinuation else {
return
}
continuation.resume()
permissionContinuation = nil
permissionLocationManager = nil
}

private func buildLocationDict(location: CLLocation) -> [String: Any] {
Expand Down
Loading