chore: bring fork up to date with apache/arrow-java v19.0.0 release#9
Open
mateusaubin wants to merge 3 commits into
Open
chore: bring fork up to date with apache/arrow-java v19.0.0 release#9mateusaubin wants to merge 3 commits into
mateusaubin wants to merge 3 commits into
Conversation
…ector offset buffer serialization (apache#989) ## What's Changed Fix `BaseVariableWidthVector`/`BaseLargeVariableWidthVector` IPC serialization when `valueCount` is 0. ### Problem When `valueCount == 0`, `setReaderAndWriterIndex()` was setting `offsetBuffer.writerIndex(0)`, which means `readableBytes() == 0`. IPC serializer uses `readableBytes()` to determine buffer size, so 0 bytes were written to the IPC stream. This crashes IPC readers in other libraries because Arrow spec requires offset buffer to have at least one entry `[0]`. This is a follow-up to apache#967 which fixed the same issue in `ListVector`/`LargeListVector`. ### Fix Modify `setReaderAndWriterIndex()` to always use `(valueCount + 1) * OFFSET_WIDTH` for the offset buffer's `writerIndex`, moved outside the if/else branch. When the offset buffer capacity is insufficient (e.g., empty buffer from constructor or loaded via `loadFieldBuffers()`), it reallocates a properly sized buffer on demand. ### Testing Added tests for empty `VarCharVector` and `LargeVarCharVector` verifying offset buffer has correct `readableBytes()` after `setValueCount(0)`. Closes apache#343 --------- Co-authored-by: Yicong Huang <yicong.huang+data@databricks.com>
Merge upstream apache/arrow-java up to b410fb2 (v19.0.0 release). Brings in: - 77df3ec apacheGH-343: Fix BaseVariableWidthVector and BaseLargeVariableWidthVector - b410fb2 MINOR: Bump version to 19.0.0 (apache#1066) Version kept at 19.0.0-iomete.1 to preserve fork release line.
rovshan-b
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges upstream
apache/arrow-javaup to commitb410fb26d— the official v19.0.0 release.Commits brought in
77df3ecb2[C++/Java] Error when reading inner lists within a struct in empty outer lists from C++/Python in Java apache/arrow-java#343: FixBaseVariableWidthVectorandBaseLargeVariableWidthVectoroffset buffer serialization (GH-343: Fix BaseVariableWidthVector and BaseLargeVariableWidthVector offset buffer serialization apache/arrow-java#989)b410fb26dMINOR: Bump version to 19.0.0 (MINOR: Bump version to 19.0.0 apache/arrow-java#1066)Notes
main(branch protections)git rerere:pom.xmlfiles kept at19.0.0-iomete.1(iomete fork version line preserved)vector/andadapter/jdbc/accepted upstream [C++/Java] Error when reading inner lists within a struct in empty outer lists from C++/Python in Java apache/arrow-java#343 fixTest plan
mvn -N help:effective-pomreports19.0.0-iomete.1vectormodule tests for [C++/Java] Error when reading inner lists within a struct in empty outer lists from C++/Python in Java apache/arrow-java#343 changes