feat(ui): show progress bar animation while models are loading#9058
Open
Pfannkuchensack wants to merge 1 commit intoinvoke-ai:mainfrom
Open
feat(ui): show progress bar animation while models are loading#9058Pfannkuchensack wants to merge 1 commit intoinvoke-ai:mainfrom
Pfannkuchensack wants to merge 1 commit intoinvoke-ai:mainfrom
Conversation
Model load events are already emitted by the backend but were only logged in the frontend. Track a loading counter via model_load_started / model_load_complete and flip the existing ProgressBar into indeterminate mode while any model is loading, so users get visual feedback that something is happening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Model load events are already emitted by the backend but were only logged in the frontend. Track a loading counter via
model_load_started/model_load_completeand flip the existingProgressBarinto indeterminate mode while any model is loading, so users get visual feedback that something is happening.Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1493251617636749443
QA Instructions
Merge Plan
Standard merge. No DB / schema / redux slice changes.
Checklist
What's Newcopy (if doing a release after this PR)