Skip to content

ci: add security scan and fix workflow findings - #175

Merged
inth3shadows merged 1 commit into
mainfrom
ci/security-scan
Nov 18, 2026
Merged

inth3shadows merged 1 commit into
mainfrom
ci/security-scan

Conversation

@inth3shadows

Copy link
Copy Markdown
Owner

What

Adds a security workflow that runs on every PR and every push to main:

  • gitleaks on the commits the event added
  • osv-scanner on the lockfiles and manifests
  • zizmor on the workflows

It also fixes everything zizmor reports today.

How

  • The three scanners are release binaries checked against pinned sha256 values (gitleaks 8.30.1, osv-scanner 2.7.0, zizmor 1.32.0), not marketplace actions.
  • Every action is pinned to a commit SHA, with its version in a comment.
  • actions/checkout sets persist-credentials: false wherever a job does not push.
  • Workflows default to permissions: contents: read.
  • release.yml: write permissions moved from the workflow to the two jobs that use them (version: contents write, to push the tag; release: contents write plus id-token, for the GitHub Release and PyPI). The uv cache is off, and pypa/gh-action-pypi-publish goes v1.14.2 → v1.14.3. version keeps its checkout credentials, because it pushes the tag.

Measured (local, 2026-11-18)

  • zizmor 1.32.0 on all workflows: no findings.
  • osv-scanner 2.7.0: no issues (or no packages).
  • CI on this PR runs the new workflow itself.

Known limits

  • Release and publish workflows do not run on PRs, so their changes are checked by zizmor and by reading, not by a run. The next release is the first real run.

@inth3shadows
inth3shadows merged commit f7b88e3 into main Nov 18, 2026
7 checks passed
@inth3shadows
inth3shadows deleted the ci/security-scan branch November 20, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant