Repository navigation
fix: report download hash mismatch error during file decryption - #49
Merged
Merged
Conversation
- Fix inverted boolean check in NetworkFacade.decryptFile that prevented hash mismatches from ever being reported - Update testShouldFailIfHashIsNotMatching to assert EnrichedError with HashMissmatch cause - Add testShouldNotFailIfHashIsNotMatchingAndIgnoreFlagIsTrue to verify ignoreHashMissmatchCheck flag
sg-gs
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Overview
In this PR, the inverted boolean condition in
NetworkFacade.decryptFileis fixed so that content hash mismatches on downloaded files are correctly reported:ignoreHashMissmatchCheck != falsetoignoreHashMissmatchCheck == false(or!ignoreHashMissmatchCheck).ignoreHashMissmatchCheckdefaults tofalse,false != falseevaluated tofalse, causing corrupted or modified files to silently pass verification without throwing an error.testShouldFailIfHashIsNotMatchingto explicitly assert theEnrichedErrorwith.HashMissmatchcause (avoiding false positives when no error was thrown).testShouldNotFailIfHashIsNotMatchingAndIgnoreFlagIsTrueto verify thatignoreHashMissmatchCheck: truecorrectly bypasses the check when requested.