Repository navigation
Optimize upload concurrency and fix S3 timeouts - #45
Merged
Merged
Conversation
- Increased URLSession timeoutIntervalForRequest to 120s for standard and multipart uploads to prevent premature drops (UPL-002). - Migrated URLSession delegate callbacks from `.main` to a dedicated background `OperationQueue`, preventing UI and XPC Main Thread blocking during heavy uploads. - Added native `withTaskCancellationHandler` support to immediately drop network requests if Swift cooperative cancellation is triggered.
internxt-dev
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the network layer's performance and resolves the S3 timeout errors reported during file uploads.
Key Changes
URLSessiondelegate callbacks from.mainto a dedicated backgroundOperationQueue. This prevents the Main Thread (qos_class_main) from being heavily burdened with progress updates during large file uploads.timeoutIntervalForRequestto 120 seconds (for both standard and multipart uploads) to improve tolerance on unstable networks.withTaskCancellationHandlersupport to instantly abort network tasks when a sync is cancelled.