Skip to content

[_]: fix: implement mail suspend on subscription change - #404

Merged
jzunigax2 merged 1 commit into
masterfrom
fix/subscription-change-mail-downgrade
Aug 31, 2026
Merged

jzunigax2 merged 1 commit into
masterfrom
fix/subscription-change-mail-downgrade

Conversation

@jzunigax2

@jzunigax2 jzunigax2 commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Mail was only ever suspended when a plan was cancelled or refunded.

Fix

Make applyMailFeatures symmetric, the tier is the source of truth, so it both
grants and withdraws:

if (enabled) {
  await this.mailService.reactivateAccount(userWithEmail.uuid);
  return;
}

await this.removeMailFeatures(userWithEmail.uuid);

@jzunigax2
jzunigax2 force-pushed the fix/subscription-change-mail-downgrade branch from b70be4e to a4b4854 Compare August 28, 2026 17:37
@sonarqubecloud

Copy link
Copy Markdown

@jzunigax2
jzunigax2 marked this pull request as ready for review August 28, 2026 17:39
@jzunigax2
jzunigax2 requested a review from sg-gs as a code owner August 28, 2026 17:39

@sg-gs sg-gs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "suspension" instead of removal is due to some product specification @jzunigax2 ? I would like to understand why the removal of the mail account switches to "suspended" if a downgrade and a cancellation implies the same: no longer access to Mail

@jzunigax2

jzunigax2 commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor Author

The "suspension" instead of removal is due to some product specification @jzunigax2 ? I would like to understand why the removal of the mail account switches to "suspended" if a downgrade and a cancellation implies the same: no longer access to Mail

yes @sg-gs, per product specification on downgrade or cancellation mail access is not inmediately revoked but rather kept in a suspended/read only state. A user could still access received mail for a 30 day period during which they can not send or receive new mail

@jzunigax2
jzunigax2 merged commit 2108a4c into master Aug 31, 2026
14 checks passed
@jzunigax2
jzunigax2 deleted the fix/subscription-change-mail-downgrade branch August 31, 2026 12:20

This branch was successfully deployed

1 active deployment
test — a4b48542 Deployed Aug 28, 2026 by jzunigax2 via Run tests (24.14.0) #1115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants