Repository navigation
[_] Internxt Meet v1.5 #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8c40be1
2531dce
b3bee16
0d8d52b
ef0ca19
ed5f393
df9e9cc
11e77d4
e4978ec
93b55fc
20dafa2
bb6b7bc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -183,9 +183,7 @@ StateListenerRegistry.register( | |
| const handlers = new Map<string, Function>(); | ||
|
|
||
| const sasAvailableHandler = (sas: object) => { | ||
| if (ConfigService.instance.isDevelopment()) { | ||
| dispatch(openDialog('ParticipantVerificationDialog', ParticipantVerificationSASDialog, { sas })); | ||
| } | ||
| dispatch(openDialog('ParticipantVerificationDialog', ParticipantVerificationSASDialog, { sas })); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the check has to appear in prod?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. That will be the best way for you guys to rule out crypto problems. If it gives problems, disable it again. But it should work just fine |
||
| }; | ||
| handlers.set(JitsiConferenceEvents.E2EE_SAS_AVAILABLE, sasAvailableHandler); | ||
| conference.on(JitsiConferenceEvents.E2EE_SAS_AVAILABLE, sasAvailableHandler); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,6 +77,10 @@ function devServerProxyBypass({ path, headers }) { | |
| return "/index.html"; | ||
| } | ||
|
|
||
| if (tpath === "/config.js" || tpath === "/interface_config.js") { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why this?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Otherwise, it was using the Jitsi config in make dev (because the path to our config was defined for prod only), and I couldn't see the difference untill changes were pushed to remote |
||
| return tpath; | ||
| } | ||
|
|
||
| if ( | ||
| tpath.startsWith("/css/") || | ||
| tpath.startsWith("/doc/") || | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t quite understand this. Does
maxSeensimply store the maximum tile size seen throughout the entire call and never decrease? Does this mean the resolution never decreases, or what effect does it have? Because it always just stores the largest valueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jitsi reduced the video quality after a few minutes, despite all other changes. It has some smart way of figuring out what quality to use, which is not working well with our customization.
I can try to remove maxSeen and check again, but paradoxically, it was the only way to stop Jitsi from reducing the video quality
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CandelR I tried removing maxSeen and resetting it to 0 in useEffect, but both resulted in quality degradation after a few minutes of the call. maxSeen blocks this degradation, but we really need to figure out how Jitsi decides video quality (highly non-trivial btw).
P.S. Video bridge ignores this and sends what it can. I think this whole quality calculation is more of an artificial limitation Jitsi sets to reduce load on the video bridge. Since we only have 10 participants (and not 100 as they support), I think we can ignore this optimization