Repository navigation
Conversation
Add the passwordless checkout groundwork: an env flag, a checkout SDK client that carries no session token, an account-setup service, and the createCustomerWithoutAccount/withoutSession option in the checkout service and payment hook. No user-facing behaviour changes yet.
Deploying drive-web with
|
| Latest commit: |
eac761d
|
| Status: | ⚡️ Build in progress... |
xabg2
marked this pull request as ready for review
September 30, 2026 09:35
CandelR
approved these changes
Oct 2, 2026
Comment on lines
+65
to
79
| const paymentIntentResponse = isPasswordlessSignUp | ||
| ? await checkoutService.createPaymentIntent( | ||
| { customerId, priceId, currency, userAddress, token, captchaToken, promoCodeId }, | ||
| { withoutSession: true }, | ||
| ) | ||
| : await checkoutService.createPaymentIntent({ | ||
| customerId, | ||
| priceId, | ||
| currency, | ||
| userAddress, | ||
| token, | ||
| captchaToken, | ||
| promoCodeId, | ||
| }); | ||
|
|
Collaborator
There was a problem hiding this comment.
nit: I think that could be simplified using withoutSession: !!isPasswordlessSignUp
xabg2
changed the base branch from
master
to
featurew/sign-up-passwordless-for-checkout
October 6, 2026 11:23
…912-checkout-without-session
xabg2
merged commit Oct 6, 2026
391c388
into
featurew/sign-up-passwordless-for-checkout
1 of 3 checks passed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First part of letting new customers pay before creating their account (PB-6873). This adds the pieces the checkout needs to work for a buyer who has no Drive session yet, without changing anything visible:
REACT_APP_PASSWORDLESS_CHECKOUT_ENABLED, off by default) that later PRs use to switch the new checkout on.Related Issues
Related Pull Requests
Checklist
Testing Process
Unit tests for the checkout service (customer, subscription and payment intent created through the client without a session for buyers without an account, and through the usual client for logged-in users) and for the payment hook.
tsc, lint and the checkout, services and core test suites pass.Additional Notes
Nothing changes for users yet: nothing calls these paths until the next PR, and the flag is off by default. The SDK version still needs to be bumped once internxt/sdk#444 is released.