Skip to content

[PB-6857]:feat/enable new currencies - #2175

Merged
jaaaaavier merged 6 commits into
masterfrom
feat/new-currencies
Sep 28, 2026
Merged

jaaaaavier merged 6 commits into
masterfrom
feat/new-currencies

Conversation

@jaaaaavier

@jaaaaavier jaaaaavier commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

The purpose of this PR is to implement everything we need for this project to enable payments in both INR and BRL.

To do this, the first step was to add the BRL symbol to the list of symbols we already have and enable both countries in the list of countries with a specific currency.

Second, we modified checkout.service.ts. Previously, the payment methods we displayed were card, PayPal, and Klarna. Since we will now have a larger list of currencies and payment methods to display, we decided to introduce the PAYMENT_METHODS constant, in which we define the methods to display based on the currency and plan, since not all are available in every country; this constant will also be used in the payments backend. Additionally, both the UPI and PIX payment methods have payment limits. We define these limits in a constant and create PAYMENT_METHOD_LIMITS, which will help us determine whether the amount the user is going to pay falls within the limit. if we do not perform this check, no payment methods will be rendered and the checkout will not function. Finally, the getPaymentMethods method is what will help us determine which payment methods are displayed.

Also we updated test related with currency and checkout services

Related Issues

Related Pull Requests

payments/feat/add-indian-rupies-as-allowed-currencies

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

To test this, we had to use Stripe's test environment. We created plans with both BRL and INR currencies, and using the credentials from this same test environment, we made purchases via cards, UPI, PIX, and PayPal to verify that both the new features and the existing ones were working properly.

Some test:
Captura de pantalla 2026-09-22 a las 10 56 59
Captura de pantalla 2026-09-22 a las 11 37 49

Additional Notes

@jaaaaavier jaaaaavier self-assigned this Sep 22, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 02af1f3
Status: ✅  Deploy successful!
Preview URL: https://05f33fd6.drive-web.pages.dev
Branch Preview URL: https://feat-new-currencies.drive-web.pages.dev

View logs

@jaaaaavier jaaaaavier added the enhancement New feature or request label Sep 22, 2026
@jaaaaavier
jaaaaavier marked this pull request as ready for review September 22, 2026 10:43
@jaaaaavier
jaaaaavier requested a review from xabg2 as a code owner September 22, 2026 10:43
@jaaaaavier
jaaaaavier removed the request for review from xabg2 September 28, 2026 06:47
@sonarqubecloud

Copy link
Copy Markdown

@jaaaaavier
jaaaaavier requested a review from xabg2 September 28, 2026 06:59
@jaaaaavier
jaaaaavier merged commit c5150ca into master Sep 28, 2026
11 checks passed
@jaaaaavier
jaaaaavier deleted the feat/new-currencies branch September 28, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants