Repository navigation
Conversation
Deploying drive-web with
|
| Latest commit: |
b37601a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ece9f1d6.drive-web.pages.dev |
| Branch Preview URL: | https://feat-name-collision-folder-m.drive-web.pages.dev |
834e9e0 to
6bc5800
Compare
6bc5800 to
c2df4b0
Compare
c2df4b0 to
f16a105
Compare
41817e2 to
890333f
Compare
f16a105 to
a1e01e8
Compare
ac46f0e to
0a5c069
Compare
64d8f9c to
fbb014d
Compare
CandelR
left a comment
There was a problem hiding this comment.
I find it odd that the ‘skip’ feature doesn’t skip uploading the folder, instead, it skips the ‘replace’ step and uploads the items into the existing folder. Has this been confirmed by Product? I find it confusing
Yes, confirmed. As explicitly stated in the ticket: Case 3 — Folder Upload The user uploads a folder containing a mix of:
If Skip is selected:
|
fbb014d to
969b12c
Compare
0a5c069 to
9bc8569
Compare
969b12c to
270c9ae
Compare
0207ead to
b794a53
Compare
270c9ae to
d9912e7
Compare
Skipping a colliding folder upload now keeps the existing folder and uploads only the files and subfolders that do not exist yet, merging colliding subfolders recursively so the folder structure is preserved.
Covers keep both for files and folders, replacing a folder, merging a skipped folder into the existing one, replace, keep both and skip for moved files, and versioned replace. The Drive mock now tracks folders, folder creation, moves and a versioning flag; moves are driven by dispatching the HTML5 drag events on the row's drop zone.
d9912e7 to
b37601a
Compare
…restore-e2e [PB-6531]: e2e coverage for same-name restore collisions
…atch [PB-6531]: resolve same-name items within a move collision batch
|




Description
Stacked on #2150, which sits on #2039. Skipping a folder that already exists now merges it into the existing one: existing files are ignored, new files and subfolders are uploaded, and colliding subfolders are merged recursively so the structure is preserved. The merge helpers live in
nameCollision.actions.tsand upload skips route to them; the unit suite covers the recursion.Second commit adds the Playwright coverage that needs this PR or its mock extensions: keep both for files and folders, replacing a folder, merging a skipped folder into the existing one, replace, keep both and skip for moved files, and versioned replace. The Drive mock from #2150 gains folders, folder creation, moves and a versioning flag; moves are driven by dispatching the HTML5 drag events on the row's drop zone (a
data-testhook on it). Flows that wait for a bucket upload never settle with the bridge blocked, so those specs assert on recorded requests and the task panel instead of the dialog closing; the versioned replace check is Chromium-only.Related Issues
Related Pull Requests
Checklist
Testing Process
yarn vitest run src/app/drive/components/NameCollisionDialogandyarn playwright test test/e2e/tests/specs/DRIVE-internxt-name-collision-resolutions.spec.ts test/e2e/tests/specs/DRIVE-internxt-name-collision-skip.spec.ts --project "Internxt E2E tests on chromium"with the dev server running.