fix: charmap error - #104
Open
Filip-Dymczyk wants to merge 2 commits into
Open
Conversation
added 2 commits
August 11, 2026 22:49
Collaborator
|
I like this, makes sense that Rich would have thought of this. Related to: #91 FYI, smpmgr is not really meant to be wrapped, since it is a user-facing CLI app. I highly recommend writing your own app with smpclient at the point you need reliability, performance, customization, etc. https://rich.readthedocs.io/en/stable/reference/console.html#rich.console.Console Please run the linters locally, rebase, and squash. |
There was a problem hiding this comment.
Pull request overview
Updates CLI progress spinners to avoid Windows charmap encoding failures.
Changes:
- Uses an ASCII-compatible spinner.
- Forces terminal rendering only when stdout is a terminal.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -1,12 +1,14 @@ | |||
| """Common CLI helpers from rich, typer, click, etc.""" | |||
|
|
|||
| import sys | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When trying to wrap the downloaded
.exein Python, I had an issue:Transport error: connection timeout - common.py:142 UnicodeEncodeError: 'charmap' codec can't encode character '\\u2826' in position\n0: character maps to <undefined>\n[PYI-27128:ERROR] Failed to execute script '__main__' due to unhandled exception!\n").Changes