Skip to content

Document the success response and call metadata for Preview Fin Voice lookups - #742

Merged
yasser-aboelgheit-intercom merged 1 commit into
mainfrom
yasser/preview-fin_voice
Oct 21, 2026
Merged

yasser-aboelgheit-intercom merged 1 commit into
mainfrom
yasser/preview-fin_voice

Conversation

@yasser-aboelgheit-intercom

Copy link
Copy Markdown
Contributor

Why?

In Preview, looking up a Fin Voice call by phone number lists only error responses, so the SDKs have no type for a successful lookup. The call response also leaves out data, the metadata sent when the call was registered. The 2.15, 2.16 and 2.17 specs already document both.

How?

Adds the success response and the data property to Preview, copied from the newer versioned specs.

Generated with Claude Code

…n the Preview spec

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@cathalging cathalging left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approve: Preview's phone lookup now documents the success response

This matches 2.15–2.17. The description of data is accurate: the API returns the metadata supplied at registration unchanged, or {} when none was supplied, so leaving the field non-nullable is right.

SDK note: additive only. collectFinVoiceCallByPhoneNumber now returns AiCallResponse, and AiCallResponse gains an optional data field.

~ Automated via Claude

@yasser-aboelgheit-intercom
yasser-aboelgheit-intercom merged commit b777439 into main Oct 21, 2026
4 checks passed
@yasser-aboelgheit-intercom
yasser-aboelgheit-intercom deleted the yasser/preview-fin_voice branch October 21, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants