Wi-Fi dialog says "Connected" after a wrong passphrase - the board fell back to its hotspot

[eliasbakken]

Found testing v1.1.0-RC8-2-g23a2bb6 on A8 s/n 0498, board on Ethernet with a WiFi dongle in hotspot mode.

What happens

Wi-Fi dialog, pick Kraakeslottet (2.4 GHz, in range), enter a wrong passphrase, press Connect. The dialog ends on:

Connected to: Kraakeslottet
Connected to Kraakeslottet.

The board never associated. reflash.log:

[info] Connection command accepted.
[info] Waiting for DHCP...
[info] Timed out waiting for IP address.
[info] Never associated with Kraakeslottet (state: disconnected). Check the passphrase.
[info] Connection failed - restoring hotspot (Recore) so the board stays reachable.
[error] WiFi Connection failed: exit status 1

Afterwards iwctl device list shows ap, and /api/wifi_poll_connect answers {"error":"exit status 1","isConnecting":false}. The UI never shows the "Could not join ... back on its own Recore hotspot" message that was written for exactly this case.

Why

watchForReconnect() in TheWifiSetup.vue treats wifi.mode === "station" && wifi.ssid === target as arrived. network-status takes ssid from iwctl's Connected network, which is already filled in while iwd is still connecting (the journal shows connecting (auto) then Deauthentication ... reason: 2). The first poll after the mode switch sees station + matching SSID, declares success, and stops watching, so the fall back to AP is never seen.

Suggested direction

Do not call it connected until the station state is connected and wlan0 has an IPv4 address. Or drive the outcome from wifi_poll_connect, which already knows the real result.

[eliasbakken]

Fixed in #158 (merged as d611c55).

Two bugs, both needed: 64871d1 stops the dialog calling it joined on a station-mode reading alone - iwctl names the network while it is still connecting - so it now needs an address and a finished attempt, and wifi_poll_connect's error ends the watch as a failure. 01b35ac fixes the case reported afterwards: asking for the network the board is already on did nothing, because iwd kept its association and the address never went away, so the script reported "Success! Connected with IP" for a passphrase it had never tested - and the server saved those credentials. wifi-connect now disconnects first.

Checked on A8 0498 in the browser: 67s of "switching", then "Could not join Kraakeslottet", never "Connected"; and again, already connected to Kraakeslottet_5GHz, with the same result.