Skip to content

Fixed code review issue in rotate/funnel_shift offsets #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieltowner merged 1 commit into from
Oct 13, 2026
Merged

Fixed code review issue in rotate/funnel_shift offsets #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/xvec/generic/generic_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,15 +953,15 @@ template<typename _Tp, std::integral _Sp, typename _Abi>
constexpr basic_vec<_Tp, _Abi> rotate_left(generic_tag, const basic_vec<_Tp, _Abi>& value, const basic_vec<_Sp, _Abi>& s) {
constexpr int numBits = sizeof(_Tp) * 8;
const auto sm = basic_vec<_Tp, _Abi>(s).to_builtin() % numBits;
const auto r = (value.to_builtin() << sm) | (value.to_builtin() >> (numBits - sm));
const auto r = (value.to_builtin() << sm) | (value.to_builtin() >> ((numBits - sm) % numBits));
return basic_vec<_Tp, _Abi>(sm != 0 ? r : value.to_builtin());
}

template<typename _Tp, std::integral _Sp, typename _Abi>
constexpr basic_vec<_Tp, _Abi> rotate_right(generic_tag, const basic_vec<_Tp, _Abi>& value, const basic_vec<_Sp, _Abi>& s) {
constexpr int numBits = sizeof(_Tp) * 8;
const auto sm = basic_vec<_Tp, _Abi>(s).to_builtin() % numBits;
const auto r = (value.to_builtin() >> sm) | (value.to_builtin() << (numBits - sm));
const auto r = (value.to_builtin() >> sm) | (value.to_builtin() << ((numBits - sm) % numBits));
return basic_vec<_Tp, _Abi>(sm != 0 ? r : value.to_builtin());
}
///@}
Expand All @@ -983,7 +983,7 @@ template<vec_unsigned_integer _Vp, vec_integral _Sp>
constexpr _Vp fsr(generic_tag, const _Vp& high, const _Vp& low, const _Sp& s) {
constexpr uint8_t numBits = sizeof(typename _Vp::value_type) * 8;
const auto sm = _Vp(s) % numBits;
const _Vp r = (low >> sm) | (high << (numBits - sm));
const _Vp r = (low >> sm) | (high << ((numBits - sm) % numBits));
return select(sm != _Vp(), r, low);
}

Expand All @@ -992,7 +992,7 @@ template<vec_unsigned_integer _Vp, vec_integral _Sp>
constexpr _Vp fsl(generic_tag, const _Vp& high, const _Vp& low, const _Sp& s) {
constexpr uint8_t numBits = sizeof(typename _Vp::value_type) * 8;
const auto sm = _Vp(s) % numBits;
const _Vp r = (high << sm) | (low >> (numBits - sm));
const _Vp r = (high << sm) | (low >> ((numBits - sm) % numBits));
return select(sm != _Vp(), r, high);
}
///@}
Expand Down
Loading