Repository navigation
pcm-power, pcm-memory: clarify unsupported client CPU error message and reference FAQ (#812) - #1060
Open
hardikkaurani wants to merge 1 commit into
Open
hardikkaurani wants to merge 1 commit into
hardikkaurani wants to merge 1 commit into
Conversation
…nd reference FAQ (intel#812) When running pcm-power or pcm-memory on client CPUs without server uncore PMU hardware (hasPCICFGUncore() == false), the tools print 'Unsupported processor model' and exit. This commonly leads users to assume the model simply lacks driver/software implementation rather than hardware PMU support. Provide an informative message explaining that server uncore PMU hardware is required and is unavailable on client processors. Direct users to the main 'pcm' utility for power, C-state, and memory bandwidth metrics on client hardware, and reference doc/FAQ.md#q5 and #q6. Addresses intel#812.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Contributor
Author
|
Hi @rdementi, Submitting a fix addressing #812 as discussed. When running This PR:
Whenever you have a chance, I would appreciate your review! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #812.
When running
pcm-powerorpcm-memoryon client processors where server uncore PMU hardware is absent (m->hasPCICFGUncore() == false), the tools currently printUnsupported processor model (0x...)and exit immediately.As discussed in #812, this message often leads users to assume that Intel PCM simply lacks software implementation or driver support for their processor model, rather than the hardware lacking the required server uncore PMUs.
Changes Made
src/pcm-power.cpp: Clarified error message when!hasPCICFGUncore():pcm-powerrequires server uncore PMU hardware not available on client or unsupported processors.pcmutility for basic power and C-state metrics on client processors.doc/FAQ.md#q5.src/pcm-memory.cpp&tests/pcm-memory-fuzz.cpp: Clarified error message when!hasPCICFGUncore():doc/FAQ.md#q6.doc/FAQ.md: Updated FAQ Q5 and Q6 answers to note that client processor users can utilize the mainpcmutility for power, C-state, and memory bandwidth metrics.