Repository navigation
📚 Add documentation for naming utilities - #423
Merged
Merged
Conversation
elbeno
requested review from
SANTOSHKUMARLAXMINARAYANRAI,
lukevalenty,
mjcaisse-intel,
nikhilshahani and
siauthun
September 17, 2026 16:31
elbeno
enabled auto-merge
September 17, 2026 16:31
lukevalenty
approved these changes
Sep 17, 2026
lukevalenty
left a comment
lukevalenty
left a comment
Contributor
There was a problem hiding this comment.
I like it. It might also be helpful to explicitly show how a name can come from a formatted ct_string. That would help readers understand a major strength.
elbeno
disabled auto-merge
September 17, 2026 16:37
Contributor
Author
|
Good call. Funnily enough I was wondering about that too :) Will add to this PR. |
Problem: - `with_name` and friends have no documentation. Solution: - Add some explanatory notes.
elbeno
force-pushed
the
named-type-docs
branch
from
September 17, 2026 17:00
64d5919 to
5dda6bb
Compare
elbeno
enabled auto-merge
September 17, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
with_nameand friends have no documentation.Solution: