Repository navigation
🎨 Add bitset::operator= from std::uint64_t - #420
Merged
Merged
Conversation
elbeno
requested review from
SANTOSHKUMARLAXMINARAYANRAI,
lukevalenty,
mjcaisse-intel and
siauthun
September 11, 2026 14:12
lukevalenty
approved these changes
Sep 11, 2026
lukevalenty
enabled auto-merge
September 11, 2026 14:14
elbeno
force-pushed
the
bitset-overwrite
branch
2 times, most recently
from
September 11, 2026 14:47
791c1f4 to
b3f1360
Compare
Problem:
- It's annoying to have to write:
```cpp
bs = decltype(bs){0b1010u};
```
when you wanted to write:
```cpp
bs = 0b1010u;
```
but can't because `bitset`'s single-argument constructor is explicit.
Solution:
- Add an assignment operator from `std::uint64_t` to match the constructor.
elbeno
force-pushed
the
bitset-overwrite
branch
from
September 11, 2026 14:47
b3f1360 to
db04827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
when you wanted to write:
bs = 0b1010u;but can't because
bitset's single-argument constructor is explicit.Solution:
std::uint64_tto match the constructor.