Repository navigation
chore: Refactor github_actions_organization_workflow_permissions - #3682
Open
stevehipwell wants to merge 1 commit into
Open
stevehipwell wants to merge 1 commit into
stevehipwell wants to merge 1 commit into
Conversation
|
👋 Hi, and thank you for this contribution! This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can. You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions. 🤖 This is an automated message. |
1 task done
stevehipwell
force-pushed
the
stevehipwell/refactor-actions-org-permissions
branch
2 times, most recently
from
October 15, 2026 11:58
de66c5c to
5633847
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
State-refresh errors and incompatible plan validation can hide permission drift or reject valid configurations.
4 open findings
What changed in this PR
These provider review instructions are being used.
This PR refactors organization-level GitHub Actions permissions, including support for disabling Actions without sending an empty policy.
Changes:
- Separates context-aware lifecycle handlers and adds plan validation.
- Expands acceptance coverage for disabled Actions and empty repository selections.
- Updates generated documentation and import examples.
| File | Description |
|---|---|
| templates/resources/actions_organization_permissions.md.tmpl | Uses generated schema, examples, and imports. |
| RESOURCES.md | Marks the resource checklist complete. |
| github/resource_github_actions_organization_permissions.go | Refactors lifecycle, validation, and state handling. |
| github/resource_github_actions_organization_permissions_test.go | Expands lifecycle and validation coverage. |
| examples/resources/github_actions_organization_permissions/resource_1.tf | Updates permissions example with SHA pinning. |
| examples/resources/github_actions_organization_permissions/import.sh | Adds CLI import example. |
| examples/resources/github_actions_organization_permissions/import-by-string-id.tf | Adds declarative import example. |
| docs/resources/actions_organization_permissions.md | Regenerates schema and usage documentation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
stevehipwell
force-pushed
the
stevehipwell/refactor-actions-org-permissions
branch
from
October 15, 2026 12:50
5633847 to
f1ecb85
Compare
stevehipwell
force-pushed
the
stevehipwell/refactor-actions-org-permissions
branch
from
October 15, 2026 13:33
f1ecb85 to
a3edd4d
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
stevehipwell/refactor-actions-org-permissions
branch
from
October 15, 2026 14:13
a3edd4d to
6fdc79b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3417
Resolves #2681
Closes #3457
Before the change?
github_actions_organization_permissionsresource wasn't working as expectedAfter the change?
github_actions_organization_permissionsresource should work correctlyPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!