Repository navigation
fix: support repository rename in github_actions_repository_oidc_subject_claim_customization_template - #3396
Conversation
…oidc_subject_claim_customization_template Related to integrations#3180
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
…ect_claim_customization_template-repository-rename
|
@deiga @stevehipwell let me know if I can do anything to facilitate the review of this change |
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @acouvreur. Could you add an empty test for the migration so we know what we need to enables when we have a pattern. Also you may want to take a look at #3476 which is the latest migration work I've done and should be the best pattern to follow.
…ect_claim_customization_template-repository-rename
…ect_claim_customization_template Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X9qLeC9Lrh4L5NG63qw3rg
|
@stevehipwell I've updated the PR to the latest recommendations and architecture guidelines, can you take a look? |
Related to #3180
Also note: #3582 changes the same resource file to add
use_immutable_subjectandsub_claim_prefix. The second PR to merge will need a rebase.Before the change?
repositoryto a different repository, the old repository keeps its custom template.After the change?
repository_idattribute anddiffRepositoryinCustomizeDiff. A rename is an in-place update. A change to a different repository forces a new resource.repository_idwith the sharedmigrateRepositoryWithIDhelper.tflog, and no read-after-write ([MAINT]: Remove read call from create/update #2892).repositoryandrepository_id.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
🤖 Generated with Claude Code