Skip to content

Support not in and is not compound operators - #301

Merged
jgardn3r merged 1 commit into
masterfrom
support-compound-operators
Aug 12, 2026
Merged

Support not in and is not compound operators#301
jgardn3r merged 1 commit into
masterfrom
support-compound-operators

Conversation

@jgardn3r

Copy link
Copy Markdown
Collaborator

This PR fixes #275.

A slight change in modelling was required to support operators that are multiple tokens. With this, more look ahead was required in several locations. That accounts for the non-compound-operator changes.

@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.22222% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...re/src/rules/optimising_line_formatter/contexts.rs 96.49% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@jgardn3r
jgardn3r force-pushed the support-compound-operators branch 2 times, most recently from 92559ba to 507f8a2 Compare May 19, 2026 23:43
@jgardn3r
jgardn3r requested a review from fourls May 20, 2026 05:47
@jgardn3r
jgardn3r force-pushed the support-compound-operators branch 2 times, most recently from bf78e32 to 68b9102 Compare May 26, 2026 01:15
Comment thread core/src/rules/optimising_line_formatter/mod.rs Outdated
@jgardn3r
jgardn3r requested a review from fourls August 11, 2026 05:01
fourls
fourls previously approved these changes Aug 12, 2026

@fourls fourls left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jgardn3r
jgardn3r force-pushed the support-compound-operators branch from 4457ef5 to 138a82c Compare August 12, 2026 04:03
@jgardn3r
jgardn3r requested a review from fourls August 12, 2026 04:03
@jgardn3r
jgardn3r enabled auto-merge (rebase) August 12, 2026 04:05
@jgardn3r
jgardn3r merged commit 64bbe1e into master Aug 12, 2026
7 checks passed
@jgardn3r
jgardn3r deleted the support-compound-operators branch August 12, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support new compound operators is not and not in

2 participants