Don't warn on closing setup window when saved settings are valid - #113
Open
Bazooper-blip wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5.
TLintSetupForm.FormCloseQueryonly checked whether the form had just been saved, so closing the External Resources Setup window with the X button always showed the "DelphiLint will not be usable" warning — even when everything was already configured correctly.The close handler now also consults the existing
IsSetupValidclass function, which validates the saved settings (the same check used to decide whether the setup window needs to be shown at all). The warning still appears when the saved configuration is genuinely invalid, i.e. when closing the window really would leave DelphiLint unusable.