SYS-685 disable gateway access logs, fix headscale for gateway - #317
Merged
Merged
Conversation
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The tailscale VPN client would not connect following migration from ingress-nginx to gateway API.
tailscale-control-protocolWhy is this change being made?
There are hundreds of misleading online suggestions for how to get headscale to work again after migration from ingress-nginx to envoy API gateway. (The tailscale up command hangs for 60 seconds, then outputs
EOF.) NONE OF THEM WORK. The rabbit holes I ran into mostly involved fruitless efforts to define an EnvoyPatchPolicy that can edit settings on the envoy pods within namespaceenvoy-gateway-system. There are suggestions involving anupgrade_configsparameter using JSONPatch. Some suggest that you need to define a two-entry list forupgrade_type, specifyingwebsocketandtailscale-control-protocol. There's even some that suggest setting aClientTrafficPolicyto specify parameters likestreamIdleTimeoutorconnectionBufferLimitBytes. Flying blind, you're told to installegctl(which relies onsocat) and type commands likeegctl x status httproute --all-namespaces. NONE OF THOSE ARE TRUE. And Gemini's AI is trained on all these outdated suggestions, which may or may not have worked with versions of Envoy Gateway before1.9.1. If you landed here after an exasperating search: see the 11-line yaml filegateway-backend.yamlattached to this PR: all you need is to define thehttpUpgradeparameter in aBackendTrafficPolicyfor the /ts2021 (or top-level "/") HTTPRoute of your headscale installation (edit: see also #318 which adjusts how this parameter is applied).How was this tested? How can the reviewer verify your testing?
Manual testing.
Completion checklist