v6: Prepare Config Changes for v6 (Refactor + Breaking Changes)#2432
Draft
aryamohanan wants to merge 19 commits intomainfrom
Draft
v6: Prepare Config Changes for v6 (Refactor + Breaking Changes)#2432aryamohanan wants to merge 19 commits intomainfrom
aryamohanan wants to merge 19 commits intomainfrom
Conversation
aryamohanan
force-pushed
the
fix-config-precedence
branch
3 times, most recently
from
0d8f6e3 to
8ff6d41
Compare
…nce (#2430) - Created a utility file for shared configuration helpers. - Moved and renamed normalizeSingleValue to resolveNumericConfig within the new utility module.
…v variable (#2431) BREAKING CHANGE: - The environment variable INSTANA_DEV_MIN_DELAY_BEFORE_SENDING_SPANS has been removed. - Please use INSTANA_TRACING_TRANSMISSION_DELAY instead.
Restructured the existing tests to improve logical grouping
- Normalization previously operated on a pre-filled in-code user config, making it unclear whether values were already present or resolved later(from env, in-code, or defaults). - This change separated input from the resulting config, making value resolution explicit and easier to follow.
BREAKING CHANGE: environment config now overrides in-code configuration. Enforces consistent precedence: env > in-code Previously inconsistent behavior is now fixed. This may impact setups relying on the old precedence. ref https://jsw.ibm.com/browse/INSTA-80965
aryamohanan
force-pushed
the
fix-config-precedence
branch
from
8ff6d41 to
7059a40
Compare
ProcessControls was setting INSTANA_TRACING_DISABLE=false for all tests where tracingEnabled=true (the default). According to the precedence rules in disable.js, when INSTANA_TRACING_DISABLE is set to 'false', it takes precedence over INSTANA_TRACING_DISABLE_INSTRUMENTATIONS and INSTANA_TRACING_DISABLE_GROUPS, preventing granular disable configurations from working in tests. This caused logging integration tests to fail when trying to disable specific instrumentations using INSTANA_TRACING_DISABLE_INSTRUMENTATIONS or INSTANA_TRACING_DISABLE_GROUPS. Changed ProcessControls to only set INSTANA_TRACING_DISABLE='true' when tracingEnabled=false, and not set it at all when tracingEnabled=true, allowing other disable environment variables to work correctly.
…olean Fixed normalizeTracingEnabled to only use INSTANA_TRACING_DISABLE for the tracing.enabled config when the env var value is 'true' or 'false'. When it contains instrumentation/group names (e.g., 'logging'), it's now handled by the separate disable normalizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes all configuration-related changes, including breaking changes and refactoring.
It is intended for the upcoming v6 branch, which will be created later, and will be merged into v6.
Breaking changes
Tasks
Migration Plan
This change will be released in the next major version (v6), planned for Q2 2026.
ref https://jsw.ibm.com/browse/INSTA-80965
Epic : https://jsw.ibm.com/browse/INSTA-817