Repository navigation
CI: the four jobs of the TopLevel, mirrored in the parent repository - #52
Merged
Merged
Conversation
One workflow, run by a pull request (a new commit cancels the previous run) or a push to main, with four jobs of fixed names for a ruleset: vhdl-syntax, unit-tests, formal and python-static-analysis. The Makefile gets the matching targets: paths, check, unit-tests and formal run the target of each repository (the repositories sit side by side as submodules, which is how their Makefiles name each other), and riscv-tools comes from the CI image. The old sim.yml and vhdl_syntax_check.yml are replaced, so no test runs twice. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kr8VNCHkZpPYMTWw5b2tY
Peng1104
marked this pull request as ready for review
November 1, 2026 04:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parent repository is becoming the top level of the project, so its CI mirrors the one of the TopLevel (and of the other repositories): one workflow with four jobs whose names are fixed, so that a ruleset can require them as status checks.
Triggers: a pull request or a push to main. A new commit in a pull request cancels the run of the previous one and starts again. sim.yml and vhdl_syntax_check.yml are replaced, so no test runs twice for the same commit. The submodules are checked out recursively and sit side by side, which is how the Makefile and the configuration of each repository name the others (../Core).
The Makefile calls riscv-tools of the CI image instead of the Tests submodule, and the targets paths, check, unit-tests and formal run the target of each repository.
Checked in the ci-vhdl image on a layout of the current main of each repository: make check passes (46 s). It cannot pass end to end yet, for reasons outside this PR:
The agent does not publish workflows, so the branch was pushed with git.