Open
Conversation
Author
|
May have another fix, when virtua detected user's scroll event, it will cancel the unfinished resize event listener |
siddharth-69
approved these changes
Jan 26, 2025
d21a75c to
18229d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am creating an AI Chat-like app. The last item is growing in height when the AI generates some message.
At a very special moment (not always reproducible), when the last item is growing in height and I use the wheel to scroll up, the scrollbar will first scroll up and then immediately snap to the bottom.
After doing some research, this is caused by
waitForMeasurement: when a user triggers ascrollToIndex,virtuawill do scrolling and listen for theUPDATE_SIZE_EVENTevent within the next 150ms. If at the same time, the last item is resizing, it will fire an actionACTION_ITEM_RESIZEto make the scroller scroll to the latest position. So if a user scrolls up within this 150ms, their operation will be overwritten by the latest scroll to the bottom.here I add a new
cancelScrollmethod to release the 150ms listener when user scroll up.Creating a demo will consume amount of my time, So I didn't provide one, if you need a reproducible demo or have any question, please let me know