test(desktop): harden divergence-probe + theme-sync smoke specs (research-validated)#311
Merged
Merged
Conversation
…arch-validated) (#2169) Implements the research-validated follow-ups from #2162 (the items that survived a /research pass on the flakiness-audit backlog): - Port detection: replace the `ps -axww` argv-scrape in the agent-patch and rename divergence probes with an in-renderer read of window.okDesktop.config.apiOrigin (the canonical value, same source as the argv; the editor-content gate already guarantees it's live). Deletes the macOS basename hack + argv-truncation / no-retry hard-fail mode. Sibling specs already read config this way. - Human-sentinel oracle: keep the reorder-tolerant single-char count (a multi-char token would be LESS CRDT-tolerant) but make the no-collision invariant explicit -- a guard assertion that the seed + agent replacement contain no sentinel char, failing loud on a future content change. - Drop the redundant wait(150) before the keystroke phase (the awaited toContainText already proves the seed converged); leave the bold-mark settle (no deterministic signal in the production renderer). - theme-sync: flatten the two already-settled 1s toPass reads to direct assertions (the awaited setThemeSource resolves only after main set the value); leave the racing toPass that needs late-resolution tolerance. Verified vs real Electron: rename 2/2 + agent-patch 5/5. theme-sync verifies on CI (does not reproduce on a local non-packaged build). Remaining #2162 items (intentional race fuzz, CI-skipped terminal-dock) left as-is per the research. GitOrigin-RevId: 9e70f4e7a95880b8ffe62e1f6ab0ad3af22eba4c
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/u/123133689?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28216623782). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.