test: cover ts_cov window semantics - #70
Merged
Merged
Conversation
initial-d
approved these changes
Sep 17, 2026
initial-d
left a comment
Owner
There was a problem hiding this comment.
Thanks, @Angelo9up. This is another focused and useful primitive-semantics test: it verifies s_cov uses trailing sample covariance and preserves the expected front-padding mask behavior. I checked the math against the implementation and verified targeted tests, full local pytest, ruff, diff check, and the GitHub CI matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ts_covtrailing-window semanticsValidation
pytest tests\test_tensor_factors.py -q— 10 passedpytest -q— all tests passedruff check tests\test_tensor_factors.py— passedgit diff --check— passed (Git only reported the Windows LF/CRLF conversion warning)This is a focused test-only change; no production implementation is modified.