Skip to content

test: cover ts_rank window semantics - #69

Merged
initial-d merged 1 commit into
initial-d:mainfrom
Angelo9up:test-edge-case
Sep 17, 2026
Merged

initial-d merged 1 commit into
initial-d:mainfrom
Angelo9up:test-edge-case

Conversation

@Angelo9up

Copy link
Copy Markdown
Contributor

Summary

  • add a focused test for ts_rank trailing-window semantics
  • verify the last element's normalized rank and front padding/output mask behavior

Validation

  • pytest tests\test_tensor_factors.py -q — 9 passed
  • pytest -q — all tests passed
  • ruff check tests\test_tensor_factors.py — passed
  • git diff --check — passed (Git only reported the Windows LF/CRLF conversion warning)

This is a focused test-only change; no production implementation is modified.

@initial-d initial-d left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Angelo9up. This is a useful focused test: it pins the trailing-window s_rank behavior and the front-padding mask semantics without changing production code. I verified the targeted tensor-factor tests, full local pytest, ruff, diff check, and the GitHub CI matrix.

@initial-d
initial-d merged commit 84d8de0 into initial-d:main Sep 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants