Repository navigation
refactor(ui): clean up after the design review - #219
Merged
Merged
Conversation
ingvarch
enabled auto-merge (rebase)
November 9, 2026 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Seven cleanups from the design review. urga behaves the same, except that the
allocations a fault narrows to are now judged at the time of the model, like
the rest of the screen.
s,t,w) are named once, and the toggleline asks for the same constants.
jobMark, on the queue screen and inthe map of the jobs list, so marks and actions read one name.
fetchListonly calledrequest: every caller now callsrequest, andfetchListis gone.allocationsPage.taketakes the time of the model instead of the wallclock, and is off the list of clock readers.
unixTimeagain.readPoolQueuesreads the queue of every node pool that has one, for boththe jobs list and the queue screen. The jobs list still fails the whole read
when a pool fails; the queue screen still shows the other pools and keeps no
read index of the jobs. The probe of the pool
defaultstays.Found along the way: no test said the pool
defaultis asked only when no poolhas a queue. A test now does.
Issues
Closes #206
Checklist
make checkis greendocs/is updated if users see a differencefeat(ui): ...,fix(nomad): ...