Repository navigation
feat(ui): warn when the token goes to a cluster without TLS - #217
Merged
Merged
Conversation
ingvarch
enabled auto-merge (rebase)
November 9, 2026 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Every request carries the ACL token. Over plain HTTP anyone on the network between you and the cluster can read it, and nothing said so. Now, when a token is set and the address is
http://to another machine, the status line warns once the cluster first answers, and again after each switch of cluster:nomad.Client.SendsTokenInCleardecides it atNew: a token is set, the scheme ishttp, and the host is notlocalhost,127.0.0.0/8or::1. A unix socket and https do not warn.InRegionkeeps the value.Connected to <name>.; the header still names the cluster.docs/configuration.mdsays when the warning appears, under Token.Checked by hand against the dev agent:
NOMAD_ADDR=http://localhost.:4646with a token shows the warning,http://127.0.0.1:4646shows nothing.Issues
Closes #201
Checklist
make checkis greendocs/is updated if users see a differencefeat(ui): ...,fix(nomad): ...