Repository navigation
refactor(nomad): name the kind of a batch queue once - #215
Merged
Merged
Conversation
ingvarch
enabled auto-merge (rebase)
November 9, 2026 22:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Nothing changes on screen. The kind of a batch queue now has one name in the code:
nomad.QueueKind, with the valuesQueueFifoandQueueDynamic. Before, the queue screen compared strings in two spellings each ("dynamic priority","dynamic_priority", and the value ofapi.BatchQueueTypeDynamic), andinternal/uiimportedgithub.com/hashicorp/nomad/apifor that one constant.internal/nomadturns the API's queue type into aQueueKindin one place,kindOf, next toqueueOffor node pools.QueueWorkload.QueueTypeandNodePool.QueueareQueueKind.queuePage.dynamic()compares withnomad.QueueDynamiconly.TestUI_DoesNotImportTheNomadAPI, fails when a non-test file ininternal/uiimportsgithub.com/hashicorp/nomad/api. The cluster's types reach the screens only throughinternal/nomad.Issues
Closes #203
Checklist
make checkis greendocs/is updated if users see a differencefeat(ui): ...,fix(nomad): ...