chore: extend lint to test files and fix the surfaced diagnostics#31
Merged
Conversation
Both packages linted `src` only; widen to `eslint src test` so tests are held to the same rules as source. Fix the pre-existing test diagnostics this surfaces: remove redundant `async` on await-free functions, wrap non-Error promise rejections (documented casts where a non-Error path is under test), bind methods passed by reference, drop unnecessary type assertions and conditions, hoist inline `import()` type annotations, and remove unused bindings.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both packages linted
srconly; widen toeslint src testso tests are held to the same rules as source. Fix the pre-existing test diagnostics this surfaces: remove redundantasyncon await-free functions, wrap non-Error promise rejections (documented casts where a non-Error path is under test), bind methods passed by reference, drop unnecessary type assertions and conditions, hoist inlineimport()type annotations, and remove unused bindings.