Repository navigation
Conversation
awarkow
marked this pull request as draft
October 19, 2026 14:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adresses #89 by adding sequencing-specific assay classes to the Common Access Model. They extend the existing generic
Assayclass so we can capture experiment metadata for whole genome, whole exome and RNA sequencing data.New Assay Classes
The new classes form a hierarchy under the existing
Assayclass:Assay
└── SequencingAssay
├── GenomicsAssay (WGS/WXS)
└── TranscriptomicsAssay (RNA-Seq)
Each subclass inherits all slots from its parent. Every sequencing assay therefore keeps the core
Assayfields (assay_id,subject_id,sample_id,file_id,assay_type, etc.) and adds its own experiment metadata.SequencingAssaySequencing Experiment Assay: a sequencing experiment performed on a Biospecimen. This is the shared base for all sequencing assays.
sequencing_center_idlibrary_nameexperiment_dateexperiment_strategyEnumSequencingStrategyis_paired_endplatformEnumSequencingPlatforminstrument_modelEnumSequencingInstrumenttotal_readsis_adapter_trimmedadapter_sequencingis_adapter_trimmedis false)quality_scaleEnumReadGroupQualityScalereference_genomeEnumReferenceGenomeworkflow_typeworkflow_type)workflow_toolworkflow_tool)workflow_versionworkflow_endpointflow_celllane_numberGenomicsAssayWGS/WXS Assay: a whole genome or whole exome sequencing experiment performed on a Biospecimen. It extends
SequencingAssaywith alignment and coverage metrics.max_insert_sizemean_insert_sizemean_depthmean_read_lengthtarget_capture_kitTranscriptomicsAssayRNA Sequencing Assay: an RNA sequencing experiment performed on a Biospecimen. It extends
SequencingAssaywith library construction details.library_strandEnumLibraryStrandlibrary_prepEnumLibraryPreplibrary_selectionEnumLibrarySelectionNew Enums
EnumLibraryPrepLibrary preparation methods for RNA sequencing. Values are drawn from OBI and constrained to subclasses of an OBI source node.
OBI:0000848OBI:0000855Open Questions
library_prepthe same thing aslibrary_construction? If so, should we rename or alias it?adapter_sequencingbe conditionally required whenis_adapter_trimmedisfalse? We could enforce this with a LinkML rule.