transpile: Remove static_initializer_is_unsafe - #1745
Merged
ahomescu merged 2 commits intoMay 8, 2026
Conversation
Rua
force-pushed
the
remove-static_initializer_is_unsafe
branch
from
April 16, 2026 22:20
567239b to
7ae9934
Compare
Rua
marked this pull request as ready for review
April 16, 2026 22:44
ahomescu
requested changes
Apr 21, 2026
Rua
force-pushed
the
remove-static_initializer_is_unsafe
branch
2 times, most recently
from
April 24, 2026 09:23
758a5ec to
b71b975
Compare
Rua
marked this pull request as draft
April 26, 2026 17:53
Rua
force-pushed
the
remove-static_initializer_is_unsafe
branch
from
May 7, 2026 08:30
b71b975 to
3dfa479
Compare
Rua
marked this pull request as ready for review
May 7, 2026 09:02
Rua
force-pushed
the
remove-static_initializer_is_unsafe
branch
from
May 8, 2026 22:02
3dfa479 to
6f8ad2e
Compare
ahomescu
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was already slated for removal in a TODO comment, and it doesn't seem like it's actually needed.
WithStmtsis handling everything already. Removing this function helps a little towards #1736 as well.