Repository navigation
test: dispose each example's engine; release notes say 0.2.1 - #57
Merged
Merged
Conversation
The release run failed its 3.10 test job on one stray thread exception: the async examples (10, 11, 14) run on aiosqlite, whose connection lives on a worker thread bound to the loop TestClient drives, and the example tests never disposed their engines, so that thread died with "Event loop is closed" after the loop stopped and pytest charged it to the next test (example 15). _client now disposes the engine inside the TestClient block, on the app's own loop. Three runs of the file and the whole suite under the runner's versions: green. The publish workflow adds one to the last version number before building, so what reaches PyPI is 0.2.1 while the tree says 0.2.0 until that bump lands on master. The CHANGELOG header, its compare links and the chart's appVersion now say 0.2.1 and the header says why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release run (#53 merged) failed the 3.10 test job of
python-publish.ymlon one stray thread exception, so nothing was published. Cause: the async examples run on aiosqlite and the example tests never disposed their engines; the connection's worker thread died with "Event loop is closed" after the loop stopped and pytest charged it to the next test._clientnow disposes the engine inside the TestClient block. Three runs of the file and the whole suite under the runner's versions: green.Also: the publish workflow adds one to the last version number before building, so the package will be 0.2.1. The CHANGELOG header, its links and the chart's appVersion say 0.2.1 now, with the reason in the header.
The separate
docker-publish.ymlrun on the master push also failed: it installslightapi[async]==<pyproject version>from PyPI, and 0.2.0 never existed there. The release image is built inline bypython-publish.ymlwith the published version, so that run is redundant; it will fail once more on this merge and pass on the next one, when master carries the bumped version.