Repository navigation
feat(series): Let a series review stand on the main the series has ported - #3002
Merged
krlmlr merged 1 commit intoOct 18, 2026
Merged
Conversation
krlmlr
added this pull request to stack #3001
October 18, 2026 13:08
krlmlr
force-pushed
the
claude/series-review-older-base
branch
from
October 18, 2026 13:53
2a8cb5c to
67217e4
Compare
…ported `series-land.sh --review --series` stood on `main` as it is, so once `main` moved past the series' last port the vendor commits stopped applying, or the review stopped equalling `main-green`, and nothing could be reviewed until the next port. With `--base`, the review stands on the older `main` commit the series has ported, which has to be an ancestor of `main`. It leaves out only the ports of that commit's history, and is held to `main-green` without its flavor exactly as before, so a base the series does not carry is refused with nothing written. Without `--base`, a refusal now names it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JXnA76zWTu4ZD8BQCSYRpk
krlmlr
force-pushed
the
claude/series-review-older-base
branch
from
October 18, 2026 14:40
67217e4 to
b6467b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/series-land.sh --review --series --base <ref>builds a series review on an oldermainthat the series has ported, an ancestor ofmain. A series that has not been forwarded cannot be replayed onto currentmain, so until now nothing could be reviewed oncemainmoved past the series' last port. It is stacked on #3000.What it changes
--base <ref>, a series review stands on thatmaincommit instead ofmainas it is. The ref has to be an ancestor ofmain, and the review leaves out only the ports in that commit's history.main-greenis unchanged. The review, without its flavor, still has to equalmain-greenoutside what it hides, so a base the series does not carry is refused with nothing written, as amainit does not carry is.--base, a refusal now names--baseas the way out, and with--baseit says that the ref is not themainthe series has ported.mainhas above it..claude/skills/series-land/SKILL.mdand the header ofscripts/series-land.shdescribe the option.Checks
scripts/series-land-test.shpasses 141 checks, 11 more than before: an older base reproduces the same SHA as the review on thatmain, and a base below a commit the series ported, a base with a change the series lacks, and a base not onmainare each refused, with the reason named.scripts/series-args-test.shpasses 96 checks.shellcheck -x --source-path=SCRIPTDIR scripts/series-land.shand the handbook check script are clean.LLM use: this PR was prepared with Claude Code (Claude Opus 5.5), at the maintainer's request.
Generated by Claude Code