Repository navigation
test: Pin the results that the igraph C core 1.0 changes - #2997
Merged
krlmlr merged 2 commits intoOct 18, 2026
Merged
Conversation
Each test passes with the vendored C core 0.10.17 and fails with 1.0.1+, so the vendor commit that changes the behaviour has to flip the expectation, and every user-visible change shows up in the review diff. Pinned: `hits_scores()` on edgeless and undirected graphs, `eigen_centrality()` on disconnected graphs, the `cluster_infomap()` code length, the edge order of `graph_from_adjacency_matrix()` and `graph_from_biadjacency_matrix()`, and the random streams of `sample_islands()`, `layout_with_gem()` and `layout_with_dh()`. The ARPACK error wording is already pinned by an existing snapshot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016jy2KuQGnR2SqMEUJ3dx35
…s test Most random graphs in the stress test are disconnected, so `eigen_centrality()` warns that some centralities are nearly zero, which emitted hundreds of warnings on a passing test. The test now checks that only this warning occurs and muffles it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L5n6BLiYoPmk3NFiYDSKZZ
1 task
krlmlr
added this pull request to stack #3001
October 18, 2026 13:00
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests that pin what
maincomputes today wherever the upcoming igraph C core 1.0 changes the result. Each test passes with the vendored C core 0.10.17 and fails with 1.0.1+, so when the vendoring series is rebuilt frommain, the vendor commit that changes a behaviour has to flip its expectation, and every user-visible change shows up in the review diff. It is stacked on #2996.What it pins
hits_scores()on an edgeless graph returnsNaNwithout a warning, and on an undirected graph it does not warn and returns the expected value (test-centrality.R).eigen_centrality()on two disconnected graphs does not warn and returns the expected vectors (test-centrality.R).cluster_infomap()code length on the karate graph (test-community.R).graph_from_adjacency_matrix()for directed input (test-adjacency.R) and ofgraph_from_biadjacency_matrix()for dense unweighted input (test-incidence.R).sample_islands()(test-games.R),layout_with_gem()andlayout_with_dh()(test-layout.R).The ARPACK error wording is already pinned by an existing snapshot, so it needs no new test.
Also included
Commit dcfe7b3 from
claude/f-nits(draft #2992) makes theeigen_centrality()stress test intest-centrality.Rexpect the "eigenvector centralities are nearly zero" warning and muffle only that one. The C core 1.0 emits it for most of the disconnected random graphs in that test, which printed hundreds of warnings on a passing test. The engine onmainnever emits it, so here the handler never fires and the test is unchanged in effect.Checks
devtools::document()andair formatchange nothing. The six touched test files pass against a build of this branch: 241 blocks, 0 failures, 0 warnings, and the one existing skip (pcalgnot installed).LLM use: this PR was prepared with Claude Code (Claude Opus 5.5), at the maintainer's request. The pinning tests come from the subsession https://claude.ai/code/session_016jy2KuQGnR2SqMEUJ3dx35, and the stress-test commit from https://claude.ai/code/session_01L5n6BLiYoPmk3NFiYDSKZZ.
Generated by Claude Code