docs: add CJM 2020 paper review (density-test PR-A) - #769
Conversation
Full methodology extraction of Cattaneo, Jansson & Ma (2020, JASA
115:531) - boundary-adaptive local polynomial density estimators and
the density-discontinuity manipulation test (the rddensity
methodology) - from the main article and its 44-page supplemental
appendix.
The review file carries a registry-ready entry: DGP/kernel assumptions
(i.i.d. sampling, continuous running variable with a fail-closed
mass-point requirement, local main-text vs global SA smoothness forms),
the EDF-smoothing estimator with Theorem 1/2 asymptotics and the
boundary-adaptive N_x scaling, unrestricted vs restricted manipulation
tests with their distinct variance contracts (additive per-side vs the
Lemma 13 coupled sandwich with the Psi reflection identity and
Moore-Penrose one-sided Gram handling), the RBC prescription
T_{p+1}(h_hat_p) (default T_3(h_hat_2)) distinguished from
undersmoothing, parity-conditioned MSE-optimal bandwidth selection
(interior even-parity second-order case included; CDF boundary
pseudo-selector limitation), a model-scoped algorithm with the
Remarks 5-6 rescaling identities, plug-in and jackknife variance
alternatives with correct localization cost bounds, the Head Start
Table 1 empirical anchors for future parity work, a tuning-parameter
table separating source defaults from simulation configurations, and
seven flagged gaps (RBC construction exists only as a main-text
prescription; the difference-objective bandwidth recipe and remaining
defaults defer to the rddensity software sources).
REGISTRY.md: one index line in the RegressionDiscontinuity 'Paper
reviews on file' block (review-only; the packaged density test remains
the documented v1 seam).
Overall assessment: ✅ Looks goodExecutive summary
MethodologyNo findings. The documented EDF estimator, weighting, Studentization, bandwidth rates, assumptions, and edge-case requirements are internally consistent with the cited CJM methodology. Code QualityNo findings; no executable code changed. PerformanceNo findings. Proposed complexity reductions are clearly identified as implementation observations requiring future parity validation. MaintainabilityNo findings. The implementation checklist and separation between paper-backed requirements and unresolved software-level choices are clear. Tech DebtNo findings. Future implementation, reference parity, bandwidth details, and unresolved source ambiguities are explicitly tracked within the review. SecurityNo findings. No secrets, PII, or executable content were introduced. Documentation/TestsNo findings. The registry index is updated consistently, and tests are not required for this documentation-only change. |
Summary
rddensityand the manipulation (density-discontinuity) test that is currently the RD toolkit's documented v1 seam. Sources: the main article plus its 44-page supplemental appendix.docs/methodology/papers/cattaneo-jansson-ma-2020-review.md) carries a registry-ready entry: assumptions (i.i.d. sampling, continuous running variable with a fail-closed mass-point requirement, main-text local vs SA global smoothness forms), the EDF-smoothing estimator with Theorem 1/2 asymptotics and boundary-adaptiveN_xscaling, unrestricted vs restricted test variants with their distinct variance contracts (additive per-side vs the Lemma 13 coupled sandwich, Psi reflection identity, Moore-Penrose one-sided Gram handling), the RBC prescriptionT_{p+1}(h_hat_p)(defaultT_3(h_hat_2)) distinguished from undersmoothing, parity-conditioned MSE-optimal bandwidth selection, a model-scoped algorithm with the Remarks 5-6 rescaling identities, plug-in/jackknife variance alternatives with correct localization cost bounds, and a tuning-parameter table separating source defaults from simulation configurations.T_q(h_hat_p)rows plus the McCrary comparison) transcribed as future parity anchors.rddensitysoftware sources.docs/methodology/REGISTRY.md: one index line in the RegressionDiscontinuity "Paper reviews on file" block (review-only; the packaged density test remains the documented v1 seam).Methodology references (required if estimator / math changes)
Validation
rddensitygolden parity and mass-point fail-closed tests)Security / privacy