Repository navigation
fix(chat): make the formatting panel readable with a bold A button - #282
Conversation
Every formatting action was shown disabled at about 1.4:1 contrast, so the panel was barely visible. Its inks now come from theme tokens only: enabled glyphs use textPrimary, labels and disabled glyphs textSecondary at full strength, cell borders textTertiary and the selected cell the brand accent, so light, dark and custom themes all stay legible. The format button in the composer strip is now a bold system-font "A" at 20pt in the same colours as its neighbouring icons. The text being typed keeps its colour.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Automated PR reviewHead: Review unavailable: Free OpenRouter review unavailable (HTTP 429); no paid fallback and no merge. Remaining gates
No PR code runs with the model key or write token. Free-only routing; provider/rate-limit failures never authorize a merge. Existing review findings must be resolved, not hidden by a new recommendation. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23826d8a27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// mirror Icon's: a 1.0 line split evenly keeps the cap height centred. | ||
| Widget _formatButtonGlyph(Color color) { | ||
| return Text( | ||
| 'A', |
There was a problem hiding this comment.
The checklist supplied with this commit explicitly leaves relevant tests unchecked and says flutter test could not run in the authoring sandbox. That explains the missing result but does not establish that testing is inapplicable; the reported simulator checks and combined-tree analysis do not supply the missing test evidence. Run the applicable tests in a supported environment, record the results, and confirm passing Quality CI for the reviewed head before approval. AGENTS.md explicitly requires requesting changes when applicable checks remain unchecked or their evidence is insufficient.
AGENTS.md reference: AGENTS.md:L19-L20
Useful? React with 👍 / 👎.
Change
The composer's formatting panel was barely visible. With no text selected, every action was drawn disabled at about 1.4:1 contrast, and the strip button used a generic font icon.
textPrimary. Labels and disabled glyphs usetextSecondaryat full strength. Cell borders usetextTertiary, and the selected cell uses the brand accent.Affected platforms: all (shared composer UI).
Related PRs and canonical PR (or
None; existing PRs checked): this is the canonical PR for this change. Open and recently closed PRs were checked; none covers it. It ships alongside #281, #283 and #284, which are independent fixes from the same request. Each touches different code and is useful alone.Telegram API Terms classification
Follow the contribution and agentic review rules. Select exactly one classification and explain it below.
This is an agentic source-code review classification. Every store version must remain compliant with applicable Telegram API Terms; the guarded-source exception does not apply to store distribution or review.
allowTelegramTosViolations(I_DONT_FUCKING_CARE_ABOUT_TOS), disabled in official builds, and available only in an explicitly enabled self-build.Reason and affected Telegram behavior:
Visual styling of an existing composer panel; no Telegram API usage or behavior changes.
Basic checks (every PR)
Check each item after verification. If a check is inapplicable, explain why in the evidence below before checking it.
dart format --output=none --set-exit-if-changed lib test integration_test test_driver.flutter analyze.flutter test --concurrency=4.Commands, results, platform/build/UI evidence, and reasons for inapplicable checks:
dart format --output=none --set-exit-if-changed lib test integration_test test_driverwith the Dart 3.12.2 SDK from Flutter 3.44.2: 0 changed.dart analyze --fatal-infos(the same analysis server and rulesflutter analyzeuses, Flutter 3.44.2 SDK): No issues found on this branch alone and on all four PRs combined.flutter testcould not run in the authoring sandbox (Alpine/musl host), so the tests box stays unchecked until Quality CI reports on this PR head. No new tests were added, at the maintainer's request.I_DONT_FUCKING_CARE_ABOUT_TOS=false). Together the four branches match the tested source, apart from two lint-only edits in fix(ios): start opened iPhone Duo panes beside the status cluster #281.Section 1.4 exception checks
Not applicable: compliant change, no guarded behavior.
--dart-define=I_DONT_FUCKING_CARE_ABOUT_TOS=false, the feature is absent and ordinary Telegram behavior remains intact.--dart-define=I_DONT_FUCKING_CARE_ABOUT_TOS=true, the feature works through the guarded entry points in a self-build; I included relevant test and build/UI evidence.falseand have no option that enables it. All store versions remain compliant with applicable Telegram API Terms.Guard locations and evidence for each flag variant: Not applicable.
Agentic reviewer confirmation
Agentic code reviewer only: record this confirmation in the PR review or check these boxes before approval.