Skip to content

Use server GC for the decompiler test suite (workstation GC on the shared Windows CI runner) #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christophwille merged 2 commits into from
Aug 19, 2026
+13 −0
Merged

Use server GC for the decompiler test suite (workstation GC on the shared Windows CI runner) #4033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f8d641
Use server GC for the decompiler test suite
christophwille Aug 15, 2026
1ddd598
Run the Windows CI test step under workstation GC
christophwille Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/build-ilspy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,13 @@ jobs:

- name: Execute unit tests
id: unit-tests
# All test hosts of the solution run concurrently on a 4-core runner. Server GC (enabled by
# ICSharpCode.Decompiler.Tests for machines it has to itself) keeps that host at 100% CPU
# and starves the neighbours: the process-module walks in ILSpy.Tests.Windows blow their
# 60 s budget and ILSpy.Tests takes almost twice as long, while the decompiler suite itself
# gains little here. The environment variable overrides the runtimeconfig setting.
env:
DOTNET_gcServer: 0
run: >
dotnet test --solution ilspy.sln
--configuration ${{ matrix.configuration }}
Expand Down
6 changes: 6 additions & 0 deletions ICSharpCode.Decompiler.Tests/ICSharpCode.Decompiler.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@

<AllowUnsafeBlocks>True</AllowUnsafeBlocks>

<!-- The suite runs dozens of allocation-heavy decompiles concurrently (one NUnit worker per
logical CPU, each roundtrip adding WholeProjectDecompiler's own Parallel.ForEach). Workstation
GC stops the whole process for every gen0/gen1 collection any worker triggers; measured on a
24-thread machine that was ~300 s of pause in a ~550 s run. Server GC gives each core its own
heap and collects in parallel. -->
<ServerGarbageCollection>true</ServerGarbageCollection>
<!-- NU1902/1903 are "Package 'X' has a known security vulnerability". In our tests, we don't care. -->
<!-- CA1416 fires because the TFM dropped its -windows suffix: Windows-only helpers (SdkUtility,
Tester.SignAssembly/FindMSBuild/RunWithTestRunner) and Windows-only test inputs (Console.CapsLock
Expand Down
Loading