Skip to content

Add tests for removeBrokenSpeciesListLinks matching on catch fraction, year and country #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Add tests for removeBrokenSpeciesListLinks matching on catch fraction, year and country #285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0d598f
Initial plan
Copilot Oct 15, 2026
6b573e9
Apply remaining changes
Copilot Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions tests/testthat/test-removeBrokenSpeciesListLinks.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,35 @@ test_that("removeBrokenSpeciesListLinks runs without errors
,NA)
})

test_that("removeBrokenSpeciesListLinks keeps all SS rows when SL links are valid", {
myObj <- importRDBESDataCSV(rdbesExtractPath = "./h1_v_20250211")
res <- removeBrokenSpeciesListLinks(myObj, verbose = FALSE)
expect_equal(nrow(res[["SS"]]), nrow(myObj[["SS"]]))
})

test_that("removeBrokenSpeciesListLinks removes all SS rows when no SL rows remain", {
myObj <- importRDBESDataCSV(rdbesExtractPath = "./h1_v_20250211")
filtered <- filterRDBESDataObject(myObj, c("SLspeclistName"), c("xxx"))
res <- removeBrokenSpeciesListLinks(filtered, verbose = FALSE)
expect_equal(nrow(res[["SS"]]), 0)
})

test_that("removeBrokenSpeciesListLinks removes SS rows when SL catch fraction does not match", {
myObj <- importRDBESDataCSV(rdbesExtractPath = "./h1_v_20250211")
expect_gt(nrow(myObj[["SS"]]), 0)
myObj[["SL"]]$SLcatchFrac <- "xxx"
res <- removeBrokenSpeciesListLinks(myObj, verbose = FALSE)
expect_equal(nrow(res[["SS"]]), 0)
})

test_that("removeBrokenSpeciesListLinks removes SS rows when SL year or country does not match", {
myObj <- importRDBESDataCSV(rdbesExtractPath = "./h1_v_20250211")
objYear <- myObj
objYear[["SL"]]$SLyear[] <- NA
expect_equal(nrow(removeBrokenSpeciesListLinks(objYear, verbose = FALSE)[["SS"]]), 0)
objCou <- myObj
objCou[["SL"]]$SLcou[] <- NA
expect_equal(nrow(removeBrokenSpeciesListLinks(objCou, verbose = FALSE)[["SS"]]), 0)
})

}) ## end capture.output