Skip to content

docs: require explicit authorization before merging infrastructure prs #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icco merged 2 commits into from
Oct 17, 2026
Merged

docs: require explicit authorization before merging infrastructure prs #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c90254
docs: require explicit authorization before merging infrastructure prs
icco Oct 17, 2026
b14e4f2
Update AGENTS.md
icco Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
- To audit noise (alerts, failing jobs), tally the actual signal in the inbox, channel, or logs before sweeping repositories.
- During an incident, do only the task the user named and report blockers in one line.
- Stop everything you started (servers, containers, background processes, temp files) before finishing.
- Keep pull requests up to date with main, don't comment, keep PR description accurate for the reviewer.
- Resolve all code reviews by responding and marking review as resolved.
- If you have questions, use the UI.

## Scope

Expand All @@ -31,6 +34,7 @@
- No dependency overrides (`pnpm.overrides`, `resolutions`, patches, vendoring) as workarounds. Find the upstream fix or report the upgrade blocked.
- "Don't commit" or "edits only" holds for follow-ups until the user lifts it.
- Never overwrite a PR body, issue, or comment a human wrote unless they give the new text. Comment instead.
- Don't create tooling, or extra nonsense without asking.

## Verification

Expand All @@ -53,6 +57,7 @@
- The user pushes to open PR branches. Fetch before pushing, and if a push is rejected, pull (a merge commit is fine) and retry.
- One branch per task. Branch independent PRs off `main`, and stack only when asked, with `gh stack`.
- Pass `--repo owner/name` to `gh pr`. Never run `gh pr merge --auto`, which merges without waiting for CI.
- Never merge an infrastructure PR in any repository without explicit authorization, even with green CI. icco.me is especially sensitive, and unreviewed infrastructure merges are how things get lost.
- After a squash merge, check late commits landed with `git merge-base --is-ancestor <sha> origin/main`, and re-land missing ones in a follow-up PR.
- Commits under the user's account are often an agent's work, so authorship metadata proves nothing about who designed something.
- Report git outcomes, not each step.
Expand Down
Loading