Repository navigation
fix: restore docker build policy and mcp validation - #18
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The production CLI install still bypasses release-age policy, and Robinhood trading tools remain accessible to restricted agents.
2 open findings
What changed in this PR
Restores pnpm release-age configuration in Docker builds and updates MCP validation for Robinhood.
Changes:
- Adds the pnpm workspace policy to the Docker context and config stage.
- Adds Robinhood to the expected MCP server list.
| File | Description |
|---|---|
.dockerignore |
Includes the pnpm workspace policy. |
Dockerfile |
Copies the policy into the config stage. |
tests/routing.test.mjs |
Expects the Robinhood MCP server. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
icco
added a commit
that referenced
this pull request
Oct 12, 2026
# Why Address #18 review findings with Robinhood denies for restricted agents and strict pnpm policy during global CLI installation. # Risks The pinned CLI and its platform packages need version-specific release-age exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Include the existing pnpm release-age policy in Docker builds and align MCP validation with Robinhood.
Risks
Docker builds now consume the same version-specific pnpm exceptions as CI.